Smoking is probably more effective at staining your teeth yellow, but I think coffee can also do it. The key here is to brush your teeth regularly as to avoid this undesired effect.